search

quotient-im / Quaternion

A Qt-based IM client for Matrix
https://matrix.org/ecosystem/clients/quaternion/
GNU General Public License v3.0
642 stars 107 forks source link

cmake build --target clean deletes quaternion_en.ts #795

Closed KitsuneRal closed 1 year ago

KitsuneRal commented 2 years ago

Seems to be a side-effect of quaternion_en.ts being passed to qt5_create_translation() - that macro comes useful to update the file but as a result CMake marks it as GENERATED(?), and generated files are supposed to be deleted on cleaning.

queria commented 2 years ago

I'm not sure, new to these things, but seems this file does get regenerated every time - with line positions changing inside whenever code change/patch is applied ... so maybe this file should be excluded from the repository and always generated at compile time?

KitsuneRal commented 1 year ago

Looks like this was a bug in Qt(?) and it was fixed - doesn't reproduce any more.