search

quotient-im / Quaternion

A Qt-based IM client for Matrix
https://matrix.org/ecosystem/clients/quaternion/
GNU General Public License v3.0
637 stars 108 forks source link

Add replying and editing support #848

Open rpallai opened 1 year ago

rpallai commented 1 year ago

Cc #596 Closes #447

rpallai commented 1 year ago

Rebased to HEAD and all suggestions from code review have been applied.

KitsuneRal commented 1 year ago

Thanks for the update! I just tried using it actually and it's a bit rough around a few edges:

  1. The unblended highlight colour is not a good choice for the background; its intended use is for foreground elements. I would suggest blending it with the base color or use RectangularGlow or another kind of frame to mark the edited/replied message.
  2. Pressing some keys (Esc, e.g.) when editing/replying removes the HUD text; the icon, the message selection, and the actual mode remain though. I would suggest using just one way to convey the mode (and I think the QToolButton next to the entry is better for that). And please make Esc actually reset the mode - it's the way Element Web works, in particular.