qupath / qupath-extension-wsinfer

QuPath extension to work with WSInfer - https://wsinfer.readthedocs.io/
Apache License 2.0
22 stars 7 forks source link

Add tiler #22

Closed alanocallaghan closed 1 year ago

alanocallaghan commented 1 year ago

JTS tiler implementation, mostly uses the same logic as tiler plugin, but adds symmetric flag, which I think is preferable

petebankhead commented 1 year ago

(Also can't merge code if it's derived from something GPL and we want to use Apache here, even if it's something GPL that I wrote [at least if I don't own the copyright]...)

alanocallaghan commented 1 year ago

That makes sense, I would have used only Geometry here but I found the creation method for rectangles a bit OTT and had evidently not noticed the geometrytools method

I'll write a new class using just the new code from the static creation method

alanocallaghan commented 1 year ago

Sounds sensible, I inferred from the methods that createGeometries would replace tile, but do correct me if I jumped the gun there

petebankhead commented 1 year ago

Sounds sensible, I inferred from the methods that createGeometries would replace tile, but do correct me if I jumped the gun there

Yeah, I'd have stuck with tile except that introducing the option to create tile objects made that confusing

alanocallaghan commented 1 year ago

I ditched the static method, can add it if it's useful if we port to QuPath, otherwise I think this is good to go