search

quran / common-components

Common components to be used across Quran.com, Quranicaudio.com and Salah.com
https://quran.github.io/common-components
41 stars 19 forks source link

Button should support href and target props #23

Open thabti opened 7 years ago

thabti commented 7 years ago

Bootstrap button has a prop for href which would style an <a> like a button and apply the href value.

mmahalwy commented 7 years ago

hmm got to careful with this and react-router

thabti commented 7 years ago

Yeah - anything I should be mindful of? There is always the onClick escape hatch. And we might eventually provide a way to support styling .

thabti commented 7 years ago

The name will still be "Button" and not Link. I will update the storybook to Button as to not be confusing.

mmahalwy commented 7 years ago

LinkContainer would work. See: https://github.com/react-bootstrap/react-router-bootstrap/blob/master/src/LinkContainer.js

thabti commented 7 years ago

Yep it would I used it on the audio repo

mmahalwy commented 7 years ago

+1