search

quran / common-components

Common components to be used across Quran.com, Quranicaudio.com and Salah.com
https://quran.github.io/common-components
41 stars 19 forks source link

some errors #7

Closed thabti closed 7 years ago

thabti commented 7 years ago

@mmahalwy

I am trying to make the npm pipe line work, however I am running in to path errors. We will have to keep everything contained. I will see what I can do about scss variables however images and such have to be contained to specific components, so we don't have to worry about paths. Unless you have any ideas.

/Users/sab/workspace/apps/audio.quran.com/node_modules/loader-runner/lib/LoaderRunner.js:109
                        throw e;
                        ^

Error: Module build failed:
@import '../../styles/variables.scss';
^
      File to import not found or unreadable: ../../styles/variables.scss
Parent style sheet: stdin
thabti commented 7 years ago

let's get the drawer component merged, then we should try to solve this issue.

thabti commented 7 years ago

I think have a solution, we drop the components so we have a more flat structure which will be like our generated lib folder on npm.

mmahalwy commented 7 years ago

+1 on that.