quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
443 stars 150 forks source link

Qaloon #186

Open g360230 opened 7 years ago

g360230 commented 7 years ago

This bug is created to add Qaloon mushaf suuport for iOS users. This is already done for android version (quran-android). Images and audio files are available in this issue : https://github.com/quran/quran_android/issues/355.

mohamede1945 commented 7 years ago

Jazak Allah khyran for creating this request. We will try to implement it inshaa'Allah.

dgharsallah commented 1 year ago

Hi, any progress on this task? I'm a Qaloon reader myself and I can probably give this task a try.

ahmedre commented 1 year ago

We are in the process of replacing the current Qaloon images with the ones from King Fahd Quran Printing Complex. That's a blocker for this issue at the moment.

dgharsallah commented 1 year ago

Can you guys get me in the loop so that I can contribute?

mohamede1945 commented 1 year ago

Are you interested in contributing to the project in general or the Qaloon Mushaf?

I've open sourced most of the code again and I'm going to write a contributions guide soon inshaa'Allah (hopefully today/tomorrow).

dgharsallah commented 1 year ago

I'm willing to take the Qaloon Mushaf task for now. Awesome! I'll wait for it and then get started with the task!

mohamede1945 commented 1 year ago

But the Qaloon task might not be ready soon, unfortunately. As @ahmedre pointed out, there is still work Ahmed is doing to get images of King Fahd Quran Printing Complex.

dgharsallah commented 1 year ago

Oh no worries, I would be happy to do that too. My definition of "task" was including that too! 😁

mohamede1945 commented 1 year ago

Thank you! cc @ahmedre

ahmedre commented 1 year ago

the work on the pages is actually done, I just need to write the upgrade logic for the Android app before this is available. I'll try to upload so the files are available and update here when done in sha' Allah.

dgharsallah commented 1 year ago

Alright awesome!