search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
460 stars 159 forks source link

SKStoreReviewController - asking for rating #214

Closed bekzattt closed 6 years ago

bekzattt commented 6 years ago

It would be nice to add SKStoreReviewController in order to increase number of people giving rating to the app.

I believe it would increase position in app store search for Quran apps. As a result more people would be able to use this ad free and so useful app!

mohamede1945 commented 6 years ago

That sounds like a great idea. Thank you for submitting it.

Do you have triggering events in mind?

bekzattt commented 6 years ago

For triggering: we could use adding to favorites, or just present it after 7 app starts.

Currently can't build the project, because of this issue (https://github.com/quran/quran-ios/issues/215)

mohamede1945 commented 6 years ago

Those are very good ideas. Thank you.

The issue has been fixed.

mohamede1945 commented 6 years ago

The build project issue is fixed. But the rating idea is not yet :)

mumer92 commented 6 years ago

Hi @mohamede1945
I would love to integrate SKReviewController as I have had experience in implementing in a project. I will open a pull request. Before that I would like to hear by you that is is the best way? When the app starts first time, then review controller should be shown or we can do like this, show review controller after 7 days when app starts?

I will implement accordingly and open a PR.

mohamede1945 commented 6 years ago

@mumer92 Thank you so much for helping out and may Allah give you high rewards in Jannah inshaa'Allah.

I would say we should ask people to review if they are really using the app and enjoying it. So, to me, someone who opened the app like 10 times in the last 7 days is using it at least once per day.

So the requirement would be: we should show the rating view if the app is opened at least 10 times and the user used the app for at least 7 days.

What do you think?

mohamede1945 commented 6 years ago

I would also add a persistent link in the settings screen to deep link into the app store for the user to review the app. But your Pull request doesn't need to include both of course.

mumer92 commented 6 years ago

@mohamede1945 Yes this seems quite right. I will try to start to implement like you suggested.