search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
462 stars 160 forks source link

Pause/Play doesnt work on first time #41

Closed waseem01 closed 6 years ago

waseem01 commented 8 years ago
  1. Launch app
  2. Tap on Surah Baqarah
  3. Tap play button at the bottom.
  4. Observe, button first shows play mode and then changes to pause mode
  5. Tap the button, the recitation doesnt stop, tap again, now it stops
  6. This happens only first time for any surah when its loaded.
waseem01 commented 8 years ago

I will fix this inshaAllah, @mohamede1945 please add me to the project so I can assign it to myself

ahmedre commented 8 years ago

@waseem01 @mohamede1945 i've added an "in progress" label that we can label things people are working on with instead of adding to the project.

waseem01 commented 8 years ago

@ahmedre Thanks, I dont have 'write permissions' to the repo to move it :)

ahmedre commented 8 years ago

we're not adding people with write permissions to the project right now for a few reasons:

  1. as a "github organization," we pay depending on the members in the organization
  2. we want to restrict checkin permissions to the code so only approved pull requests get merged

i also looked to see if there's a way to just give permissions to add labels and what not, but i didn't see that, though i could have missed it.

ahmedre commented 8 years ago

as an aside, most open source projects work this way - i.e. you don't get write permissions to most of the repositories to be able to contribute - the maintainers are responsible for looking at pull requests, reviewing them, and merging code accordingly.

ahmedre commented 8 years ago

oh - and i forgot, most importantly - jazakAllah khairan in advance!

waseem01 commented 8 years ago

Thanks, I will open a PR and I guess the admin can merge.

mohamede1945 commented 8 years ago

@waseem01 I don't know why I'm not able to reproduce the issue. Can you have tell me which reciter were you using?

mohamede1945 commented 8 years ago

@ahmedre Thanks a lot for creating the label. I was mainly depending on zenhub for such things, but I think I should use labels too since it will be easier for everyone.

mohamede1945 commented 8 years ago

Gif of the issue: g7jxoq

mohamede1945 commented 8 years ago

I'll start working on this issue now.

mohamede1945 commented 6 years ago

Can't reproduce anymore.