search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
456 stars 156 forks source link

Compilation error building for MacOS! #417

Closed amirian closed 1 year ago

amirian commented 1 year ago

This code wouldn't compile in the latest xcode version, several build errors as below: AnyPublisher is only available in mac 10.15 or newer PassthroughSubject is only available in mac 10.15 or newer erasetoAnyPublisher() is only available in mac 10.15 or newer map is only available in mac 10.15 or newer

mohamede1945 commented 1 year ago

Thanks for reporting this. The library doesn't Mac OS, just iOS (see https://github.com/quran/quran-ios/blob/main/Package.swift#L9).

If you would like to add support for Mac OS, that would be great.

amirian commented 1 year ago

No, I just decided to make some extensions on iOS, but I wonder you have made all the parts private except the engine! That was public in past.

mohamede1945 commented 1 year ago

Yeah, that was a decision to allow other people interested in creating their own Quran app to not have to worry about the business logic and can reuse an existing engine for that and build their UI and other features on top of the engine.

mohamede1945 commented 1 year ago

I'm going to close the issue given that we are not going to support Mac OS.