search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
456 stars 156 forks source link

Fix retain cycle in DownloadBatchDataController #462

Closed mohamede1945 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #462 (73578d3) into main (5c9504b) will decrease coverage by 0.05%. The diff coverage is 52.17%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   81.18%   81.14%   -0.05%     
==========================================
  Files         200      201       +1     
  Lines        7474     7484      +10     
==========================================
+ Hits         6068     6073       +5     
- Misses       1406     1411       +5
Impacted Files Coverage Δ
...s/BatchDownloader/Downloader/DownloadManager.swift 76.31% <0.00%> (ø)
...es/BatchDownloader/Downloader/NetworkSession.swift 0.00% <ø> (ø)
Sources/Utilities/Features/Address.swift 0.00% <0.00%> (ø)
...it/VersePersistence/GRDBVerseTextPersistence.swift 70.47% <20.00%> (ø)
...oader/Downloader/DownloadBatchDataController.swift 94.23% <85.71%> (+0.11%) :arrow_up:
...wnloader/Downloader/GRDBDownloadsPersistence.swift 98.59% <100.00%> (ø)
Sources/TestUtilities/NetworkSessionFake.swift 82.17% <100.00%> (ø)
...ts/BatchDownloaderTests/DownloadManagerTests.swift 100.00% <100.00%> (ø)