quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
462 stars 160 forks source link

Remove PromiseKit from TranslationService #466

Closed mohamede1945 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #466 (a9266e2) into main (c7d63b3) will increase coverage by 0.12%. The diff coverage is 94.87%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   86.45%   86.57%   +0.12%     
==========================================
  Files         190      190              
  Lines        7089     7064      -25     
==========================================
- Hits         6129     6116      -13     
+ Misses        960      948      -12     
Impacted Files Coverage Δ
...urces/BatchDownloader/Network/NetworkManager.swift 83.33% <ø> (-5.13%) :arrow_down:
...anTextKit/Search/Searchers/CompositeSearcher.swift 80.48% <ø> (ø)
...TextKit/Search/Searchers/TranslationSearcher.swift 100.00% <ø> (ø)
...ranslationService/LocalTranslationsRetriever.swift 100.00% <ø> (+10.71%) :arrow_up:
...ranslationService/TranslationsVersionUpdater.swift 97.29% <ø> (ø)
...es/Utilities/Extensions/PromiseKit+Extension.swift 46.66% <ø> (+18.66%) :arrow_up:
...tionServiceTests/TranslationsRepositoryTests.swift 75.53% <66.66%> (+0.53%) :arrow_up:
...oader/Downloader/DownloadBatchDataController.swift 94.23% <100.00%> (ø)
Sources/TestUtilities/Utils.swift 82.08% <100.00%> (-1.79%) :arrow_down:
...ources/TranslationService/TranslationDeleter.swift 100.00% <100.00%> (ø)
... and 4 more