quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
463 stars 160 forks source link

Create Quran Completions Feature #541

Open selim opened 1 year ago

selim commented 1 year ago

Please add a rename button beside the delete button in bookmarks. When user click the rename button and enter the name, show that name at beside (left/right) of current bookmark label.

It's will be great benefit for readers following multiple (completion) positions for reciting Quran same time.

mohamede1945 commented 1 year ago

Salam alikom,

Just to ensure I've understood the scenario correctly: A user aims to complete multiple readings of the Quran concurrently, and hence, requires a method to track their progress in each reading. One way to do that is to use bookmarks. So, your suggestion is to attach labels to these bookmarks, allowing users to easily identify which Quran reading each bookmark corresponds to, correct?

If that's correct, maybe we need to brainstorm multiple ideas.

selim commented 1 year ago

Alaikum salam,

Yes correct...
One user aims to complete concurrently with multiple readings same time,

Use cases:

  1. There is groups for Juz sharing, and a user needs to follow each group, a sample Juz sharing group:

    image
  2. Same time user aims to complete multiple readings concurrently for different purposes,

  3. Each completion must be follow independently, may be scheduled.

an idea ->

mohamede1945 commented 1 year ago

I believe it's a perfectly valid use case. However, I'm still uncertain if utilizing named bookmarks is the optimal solution. I've been considering the development of a feature called 'Completions'. This would allow users to initiate and track multiple Quran reading completions. Each completion could be optionally named, and the system would monitor their progress. Additionally, it would provide users with extra details about their reading journey, such as the amount remaining to read, which specific pages they haven't tackled yet, when they started each completion, as well as their average time spent on each page, among other insights.

In terms of future enhancements to this feature, we could incorporate Quran daily verses (Daily Werd) into the completions, with daily notifications.

What are your thoughts on this?

selim commented 1 year ago

Perfecto; Completion's feature which you mentioned is what we need. But please, we do not want to wait for 1 year. All users will be happy if released asap.

mohamede1945 commented 1 year ago

I'll do my best. May Allah help me finish it soon.

selim commented 1 year ago

I saw many issues would be solved with "Completion Feature". May be we can review old requests and merge with "Completion Feature" and develop just one sprint or in milestone (https://github.com/quran/quran-ios/milestone/10):

377

346

307

287

172

309

96

But ASAP :)

selim commented 1 year ago

Any iterations for "Completion Feature" ?

mohamede1945 commented 1 year ago

No, I'm currently traveling, will be back mid October. Plus, I have other in-progress features that I'll be focusing on when I return. This feature is open for contribution, so feel free to jump in! :)

AhmedG commented 8 months ago

I think this would work well with a scheduling system (reminder to read). I will say Tarteel has some options surrounding this but I am hoping for something more flexible here and not just reliant on you reading but even just listening.