quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
446 stars 153 forks source link

Always show advanced audio options button #556

Closed zukhan closed 1 year ago

zukhan commented 1 year ago

Currently, in order to change any of the advanced audio options, you first need to hit the play button. This change displays the advanced audio options button on the reciter bar so you can change the audio settings without hitting play first.

Before and After:

audio_options (before   after)
codecov[bot] commented 1 year ago

Codecov Report

Merging #556 (a2347cf) into main (e550546) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   41.15%   41.12%   -0.03%     
==========================================
  Files         495      495              
  Lines       19011    19026      +15     
==========================================
+ Hits         7824     7825       +1     
- Misses      11187    11201      +14     
Files Changed Coverage Δ
...AudioBannerFeature/AudioBannerViewController.swift 0.00% <0.00%> (ø)
...ures/AudioBannerFeature/AudioBannerViewModel.swift 0.00% <0.00%> (ø)
...tures/AudioBannerFeature/AudioReciterBarView.swift 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

mohamede1945 commented 1 year ago

Looks awesome! Jazak Allah khyran.