search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
446 stars 153 forks source link

Fix russian transliteration strings for surahs titles #558

Closed aziev closed 1 year ago

aziev commented 1 year ago

Titles for some surahs are incorrect in russian. This PR fixes them.

mohamede1945 commented 1 year ago

Thank you for your contribution. However, I'm sourcing the translations from the Android repository. It would be best if you could make the fix there. Before the upcoming release, I'll import the updated translations.

Here's the file for your reference: sura_names.xml in the Android repo.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a8108f) 41.12% compared to head (c0d8c2a) 41.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #558 +/- ## ======================================= Coverage 41.12% 41.13% ======================================= Files 495 495 Lines 19026 19026 ======================================= + Hits 7825 7826 +1 + Misses 11201 11200 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/quran/quran-ios/pull/558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aziev commented 1 year ago

@mohamede1945 it seems to be fixed in the android app. جزاك الله خيرا

mohamede1945 commented 1 year ago

Awesome! Jazak Allah Khairan for your help and verification, @aziev! I'll go ahead and merge this PR. That way, the next time I import translations, I can use your changes as a reference to ensure everything matches up. Thank

you!