quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
446 stars 153 forks source link

Improve search functionality #578

Closed mohamede1945 closed 10 months ago

mohamede1945 commented 10 months ago

TODO:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (79fa74e) 41.16% compared to head (dcfadbc) 41.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #578 +/- ## ========================================== - Coverage 41.16% 41.16% -0.01% ========================================== Files 495 494 -1 Lines 19019 19017 -2 ========================================== - Hits 7830 7828 -2 Misses 11189 11189 ``` | [Files](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran) | Coverage Δ | | |---|---|---| | [...tKit/Sources/Search/Searchers/NumberSearcher.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvTnVtYmVyU2VhcmNoZXIuc3dpZnQ=) | `96.92% <100.00%> (+2.63%)` | :arrow_up: | | [...Sources/Search/Searchers/PersistenceSearcher.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvUGVyc2lzdGVuY2VTZWFyY2hlci5zd2lmdA==) | `92.30% <100.00%> (+18.97%)` | :arrow_up: | | [...extKit/Sources/Search/Searchers/SuraSearcher.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvU3VyYVNlYXJjaGVyLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [...Sources/Search/Searchers/TranslationSearcher.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvVHJhbnNsYXRpb25TZWFyY2hlci5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [...in/QuranTextKit/Tests/CompositeSearcherTests.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9UZXN0cy9Db21wb3NpdGVTZWFyY2hlclRlc3RzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Features/SearchFeature/SearchViewModel.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RmVhdHVyZXMvU2VhcmNoRmVhdHVyZS9TZWFyY2hWaWV3TW9kZWwuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...erseTextPersistence/GRDBVerseTextPersistence.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RGF0YS9WZXJzZVRleHRQZXJzaXN0ZW5jZS9HUkRCVmVyc2VUZXh0UGVyc2lzdGVuY2Uuc3dpZnQ=) | `93.33% <60.00%> (+0.06%)` | :arrow_up: | | [...t/Sources/Search/Searchers/CompositeSearcher.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvQ29tcG9zaXRlU2VhcmNoZXIuc3dpZnQ=) | `81.96% <86.66%> (-1.37%)` | :arrow_down: | | [...nTextKit/Sources/Search/Searchers/SearchTerm.swift](https://app.codecov.io/gh/quran/quran-ios/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quran#diff-RG9tYWluL1F1cmFuVGV4dEtpdC9Tb3VyY2VzL1NlYXJjaC9TZWFyY2hlcnMvU2VhcmNoVGVybS5zd2lmdA==) | `95.34% <95.34%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.