search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
444 stars 150 forks source link

Issue with ‘Container’ class and Missing arguments for parameters 'downloader', 'remoteResources #624

Closed looktaking closed 7 months ago

looktaking commented 7 months ago

Assalamu Alaikum,

May Allah bless everyone who works on this project for the noble efforts in creating this app.

I recently cloned the Quran iOS project and tried to run the example, but I came across a few issues.

The Container class does not conform to the AppDependencies protocol. It seems like the Container class is missing the following properties required by the AppDependencies protocol:

quranUthmaniV2Database logsDirectory databasesDirectory remoteResources

I tried to provide default values for these properties, but I’m not sure if that’s the correct approach. Could you please provide some guidance on how to properly implement these properties in the Container class?

    var quranUthmaniV2Database: URL { return URL(string: "https://")! }
    var logsDirectory: URL { return URL(string: "https://")! }
    var databasesDirectory: URL { return URL(string: "https://")! }
    var remoteResources: ReadingRemoteResources? { return nil }

image

mohamede1945 commented 7 months ago

We alikom elsalam,

the latest commit passed CI: https://github.com/quran/quran-ios/commits/main/. I think you may be using the xcode project and not the workspace.

Please take a look at the CI command, we are doing xcrun xcodebuild build -workspace Example/QuranEngineApp.xcworkspace -scheme QuranEngineApp. You need to open QuranEngineApp.xcworkspace.

looktaking commented 7 months ago

Thank you for your guidance, using QuranEngineApp.xcworkspace instead of the Xcode project, solved my issues.

I appreciate your prompt and helpful response.