Closed yismailuofa closed 2 months ago
Attention: Patch coverage is 68.42105%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 39.68%. Comparing base (
d9fc366
) to head (82e6d21
). Report is 12 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
Features/NotesFeature/NotesViewModel.swift | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Oh, this is amazing find. I didn't know about this.
I think this is best suited to be implemented in:
This way it will be useful for any sharing functionality not just the notes sharing including sharing or copying quran text from the main quran page.
PS:
make format-autocorrect
I think this is best suited to be implemented in ...
- Please ensure to update tests: https://github.com/quran/quran-ios/blob/592e0e895c53ae3bb357b1e8946e3a34edffca80/Domain/QuranTextKit/Tests/ShareableVerseTextRetrieverTests.swift
- Please ensure to run
make format-autocorrect
Refactored it out and updated the tests to match (and formatted it this time 😅 )
Jazak Allah khyrn! Looks amazing! I'll merge the PR as soon as the CI finishes.
Tries to fix the issue with brackets in texts with bidirectional languages by nesting the arabic text with unicode characters
Based off of these Apple Docs and this Stack Overflow
https://github.com/user-attachments/assets/45397e0b-3844-495f-8933-ae590ffb4a88