Tafseer view and notes view has English numbers for Ayat despite app language being Arabic

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.

Apache License 2.0

462 stars 160 forks source link

Closed MahmoudAlyuDeen closed 2 months ago

MahmoudAlyuDeen commented 2 months ago

Tafseer	Notes

mohamede1945 commented 2 months ago

I tried to repro the issue but I couldn't. I hope Youssef's PR has fixed it. Do you mind if you can test it in the example app?

MahmoudAlyuDeen commented 2 months ago

Sure I can try it. Thanks for the follow up.

❓ Is there an ipa or do I need to build it?

mohamede1945 commented 2 months ago

Usually you need to build, but I've sent a new release for review. So, hopefully later today you can download it and verify.

mohamede1945 commented 2 months ago

The new version is on the app store. Can you try it please?

MahmoudAlyuDeen commented 2 months ago

Fixed 🚀

mohamede1945 commented 2 months ago

Thanks @MahmoudAlyuDeen for verifying and thank you @yismailuofa for the fix.