search

quran / quran-ios

QuranEngine is the engine powering the Quran.com iOS app.
Apache License 2.0
462 stars 160 forks source link

Fix Arabic Number Bug and Improve Notes Sharing #667

Closed yismailuofa closed 2 months ago

yismailuofa commented 2 months ago

  1. Fixes #666, I think maybe Apple changed the locale keys in the new update ? The docs say it uses BCP-47. So updated the string to use this.

  2. Refactors the sharing abit to make it more consistent, since sometimes English and Arabic would be on the same line, now we add newlines properly I think.

  3. Updates the ayah sharing to use the same logic as copy. Before copy would have newlines and sharing didn't but now they should both have it.

Image 7630 Image 7631
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 39.56%. Comparing base (d9fc366) to head (c40fb5c). Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
Features/NotesFeature/NotesViewModel.swift 0.00% 12 Missing :warning:
Features/AyahMenuFeature/AyahMenuViewModel.swift 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #667 +/- ## ========================================== - Coverage 40.92% 39.56% -1.37% ========================================== Files 525 526 +1 Lines 20880 19505 -1375 ========================================== - Hits 8546 7717 -829 + Misses 12334 11788 -546 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohamede1945 commented 2 months ago

Jazak Allah Khyrn Youssef for fixing them.

I tried to repro #666 but I couldn't.

yismailuofa commented 2 months ago

@mohamede1945 For reference, I’m on ios18. Maybe #666 is as well?

mohamede1945 commented 2 months ago

Oh, I see. I'm still on ios 17. Also, I've sent a new version for review.