quran / quran.com-api

Quran.com content APIs
https://api-docs.quran.foundation/docs/category/content-apis
MIT License
930 stars 194 forks source link

Add missing waqf sign in v2 #570

Closed naveed-ahmad closed 2 years ago

naveed-ahmad commented 2 years ago

Missing in our fonts

naveed-ahmad commented 2 years ago

p60-v2.zip

benomaire commented 2 years ago

A kind reminder that v2 fonts match the print between 1422-1438. Therefore, the font is correct and no change is needed, see the image below. The first image that you showed is for v4 fonts (available here) which match the print after 1439.

p060

naveed-ahmad commented 2 years ago

@benomaire JAK, closing this.

fyi we're going to add v4 in the next few week inshAllah, fonts file are already splitted into 604 files. Any idea what happens to v3?

benomaire commented 2 years ago

Unfortunately, no idea. But it could be a version that matches Shemerly.

BTW, I would have tried to live with the new format without expanding the fonts to 604 fonts again. Benefits are

  1. Compatibility with anybody who uses them directly from the Complex, especially if we offer a sharing feature.
  2. We're confident that font hashes are exactly the same, so if any weird rendering bug is reported for example, we are sure it is not the font.

I agree that dealing with much less fonts is a bit confusing and a bit heavier on the web, but just wanted to share these thoughts.