quran / quran.com-frontend-next

Frontend build on next.js
https://quran.com
1.41k stars 420 forks source link

[bug]: links goes to github 404 in README.md #1906

Open moHaHa opened 1 year ago

moHaHa commented 1 year ago

Is there an existing issue for this?

Describe the bug

when I'm reading these repo docs (README.md file ) I found this link We also display all our components here, so I want to see this component but this link goes to not found page. and there more than one link goes to not found page

Relevant log output

No response

Steps to reproduce

  1. Go to this repo github.com/quran/quran.com-frontend-next
  2. Scroll to #storybookjs or just click on this link https://github.com/quran/quran.com-frontend-next#storybookjs
  3. click on "We also display all our components here." colored blue
  4. you will get not found page (404)

Environment (please complete the following information) and Add any other context about this bug

Browser: Chrome

Environment

Production(quran.com)

hazem3500 commented 1 year ago

Related #1893 Related #1882

moHaHa commented 1 year ago

Related #1893

I want to mention that the results of this issue shows in https://quran.github.io, (Github pages ) not inside the repository, that means the problem is one of two choices

image image

hazem3500 commented 1 year ago

Yup 😄

I'm not sure if Storybook is properly hosted 🤔 We need to check if there is a problem in the storybook hosting and then update the link in the README to point to the correct URL 👍

njmulsqb commented 1 year ago

I am willing to work on this, please assign to me