search

quran / quran.com-frontend-next

Frontend build on next.js
https://quran.com
1.31k stars 381 forks source link

wip: generate sharable image #2090

Open muhajirdev opened 4 months ago

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 3:35pm
anaslaham commented 3 months ago

@muhajirdev thank you brother for adding this feature but I found a bug when sharing a large Ayah the modal overflows and I can't scroll.

image

SaadUlHassan commented 3 weeks ago

Found 1 more bug

image

Reproducing steps

  1. Navigate to APP/2?startingVerse=1 or any small verse.
  2. Click on More Icon button ( ... )
  3. More options will pop up and click on Share Image
  4. You will be able to see that the image with verse doesn't cover the whole container.
SaadUlHassan commented 3 weeks ago

Can i raise the PR for remaining work & fixes for this feature ? @osamasayed