quran / quran.com-frontend-next

Frontend build on next.js
https://quran.com
1.31k stars 381 forks source link

[feature]: Light theme Tajweed color rules in Dark Mode #2101

Open LomariPortfolio opened 4 months ago

LomariPortfolio commented 4 months ago

Is there an existing issue for this feature?

Summary

The Light mode Tajweed color rules look a lot better than the Dark mode ones, as it causes me eye strain when trying to differentiate between "Permitted Maad 2 or 4 or 6 seconds", "Necessary Maad 4 or 5 seconds" and "Maad 2 seconds" colors

image image

It seems the color codes for them (in dark mode) are:

d21ffb Maad 2 seconds

ee30fa Permitted Maad 2 or 4 or 6 seconds

ff55f1 Necessary Maad 4 or 5 seconds

I tried to compare them in Adobe Colors and they don't seem to be that much different:

image

image

image

image

Your purposed solution for this feature

Using the Light Mode version of the Tajweed color rules would be sufficient to stop users from having eye strain, also maybe using HSL/HSB instead of RGB can help making sure the colors contrast well.

And Jazakum Allah (Subhanahu Wa Ta'ala) alfa khair | وجزاكم الله سبحانه وتعالى ألف خير

sharabash commented 2 weeks ago

Or perhaps customizable tajweed color settings for the next generation tajweed mushaf implementation (assuming we're implementing as a character-by-character font @osamasayed)

osamasayed commented 2 weeks ago

Or perhaps customizable tajweed color settings for the next generation tajweed mushaf implementation (assuming we're implementing as a character-by-character font @osamasayed)

We are working on adding a much higher-quality version of the Tajweed Mushaf that will have an in-Quran-Reader Tajweed rules section with fixed colors in the first version so users don't have to go back and forth between the Quran Reader and the Tajweed rules page and we will remove the dedicated rules pages as it will no longer be needed. Product details can be found here QF-545