quran / quran.com-frontend-next

Frontend build on next.js
https://quran.com
1.31k stars 381 forks source link

made the verse actions popup close automatically after the user starts playing a verse #2126

Open 0XYoussefX0 opened 3 months ago

0XYoussefX0 commented 3 months ago

Summary

when the user opens the modal to repeat a verse and clicks the start playing button, the modal stays open, This PR fixes that. this fix was already requested by users in here

Screenshots

Before After
Before_1 After_2
vercel[bot] commented 3 months ago

@0XYoussefX0 is attempting to deploy a commit to the Quran Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 8:34pm
0XYoussefX0 commented 3 months ago

@osamasayed can you please review my PR?

osamasayed commented 3 months ago

@osamasayed can you please review my PR?

Alsalmau Alikum brother, Jazak Allahu Khairan for your contribution. Before I am able to review it please make sure it can build successfully as currently it's not working. You can try to run "yarn build" locally first.

0XYoussefX0 commented 3 months ago

@osamasayed done 👍