quran / quran.com-frontend-next

Frontend build on next.js
https://quran.com
1.3k stars 380 forks source link

Only allow Joyride on client side #2150

Closed osamasayed closed 2 months ago

osamasayed commented 2 months ago

Summary

This PR fixes an issue that was preventing the server from rendering the HTML correctly resulting in missing all meta tags including preview links etc by only loading Joyride package on the client side.

curl "https://localhost:3000/1" Before vs after:

Screenshot 2024-05-04 at 7 22 54 PM
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview May 4, 2024 4:23pm