quran / quran.com-frontend-next

Frontend build on next.js

https://quran.com

1.37k stars 398 forks source link

Fix indopak translation mode missing ayahs #2166

Closed AhmedCodeGuy closed 3 months ago

AhmedCodeGuy commented 3 months ago

Summary

Fixes #QF-469

Fetch page's verses data on the client to specify the select mushaf ID instead of always using the default mushaf ID which is Uthmani.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Test plan

This has been tested on chrome with different pages following this route: /page/[pageId] using Indopak, 15 lines, translation mode.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Screenshots or videos

Before	After

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quran-com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2024 10:38am