quran / quran.com-frontend-next

Frontend build on next.js

https://quran.com

1.3k stars 380 forks source link

QF-613-word-by-word-in-settings-dynamic-list #2185

Open AhmedCodeGuy opened 2 days ago

AhmedCodeGuy commented 2 days ago

Summary

Fixes #613

Changes the word by word settings translations from static list to dynamic list fetched from the API.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Test plan

The list is fetched dynamically and the UI matches the data fetched from the API, after filtering dublicate translations for the same language.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quran-com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 4, 2024 11:39am