quran / quran.com-frontend-v2

https://quran.com
GNU General Public License v3.0
453 stars 199 forks source link

Wrong text rendering when "Uthmani Text" or "Tajweed Text" is selected #289

Closed YousufSohail closed 3 years ago

YousufSohail commented 3 years ago

Please see attached screenshots:

Screenshot 2020-12-15 at 8 52 42 PM Screenshot 2020-12-15 at 8 52 27 PM
aboqasem commented 3 years ago

Assalamualaykum, Jazakumullahu Khairan, this is my first time here and my first time dealing with Ruby, Rails, and Postgres.

I was trying to debug this issue, and I checked on the database by comparing both Alif-Lãm-Mĩms form Ali 'Imran and Al-Baqarah chapters, I executed:

SELECT * FROM quran.verses
WHERE chapter_id = 2 AND verse_number = 1

then

SELECT * FROM quran.verses
WHERE chapter_id = 3 AND verse_number = 1

The comparison looks clean:

diff

So I think the problem is not caused by the database, still learning Rails and debugging...

YousufSohail commented 3 years ago

@aboqasem how can I access db?

aboqasem commented 3 years ago

Just follow the instructions for setting up the project locally, then use pgAdmin to run the queries.

benomaire commented 3 years ago

probably the problem is with "Uthmani Text" alone.

  1. In translation mode, "Tajweed Text" is correct, and colored, as expected!
  2. In reading mode, "Tajweed Text" looks exactly like "Uthmani Text". Screenshots above
Screenshots for translation mode "Uthmani Text": ![img2](https://user-images.githubusercontent.com/69304392/102491397-2aebfe00-4081-11eb-8551-adf274befdb5.png) "Tajweed Text": ![img1](https://user-images.githubusercontent.com/69304392/102491391-29223a80-4081-11eb-8211-b8bb78ab3be8.png)
naveed-ahmad commented 3 years ago

Salam everyone, fixed this on beta.quran.com will be pushed live in few days inshAllah.

benomaire commented 3 years ago

جزاكم الله خيرا But still "Tajweed Text" and "Uthmani Text" are the same in reading mode.

naveed-ahmad commented 3 years ago

That's intentional. In reading more we are showing word-by-word text and we don't have wbw tajweed text yet.