search

quran / quran.com-frontend-v2

https://quran.com
GNU General Public License v3.0
453 stars 199 forks source link

Bismillah text fix #479

Closed acen20 closed 3 years ago

acen20 commented 3 years ago

'Bismillah' text alignment

Greetings. I have been noticing for a while that the 'Bismillah' text is partially hidden. Moreover, it completely disappears as I reduce the window size. I have also figured out why it's happening. It is due to the font-size property. Font-size was changed from 40px to 2.4rem and apparently, it has fixed the problems.

Before

Bismillah partially hidden

Bismillah_Partially_Hidden

Bismillah Disappeared on small window

![Bismillah_disappeared_On_Small](https://user-images.githubusercontent.com/62377713/129139595-23f37748-e3bf-48de-891e-1c171ec32050.png)

After

Complete text on full window

Screenshot from 2021-08-12 10-53-48

Text is also visible on small window

![Screenshot from 2021-08-12 10-54-08](https://user-images.githubusercontent.com/62377713/129146572-87c81874-396b-40c2-a7c6-dc3e31e9c6a5.png)
naveed-ahmad commented 3 years ago

jazakAllah kaharain for the PR brother. We're migrating frontend to nextjs https://github.com/quran/quran.com-frontend-next

Can you please open this PR on nextjs? Going to close this as we don't want to make any frontend change here from now on.