search

quran / quran.com-frontend

quran.com frontend
https://quran.com
MIT License
994 stars 360 forks source link

Convert Smartbanner to styled-components #1020

Open mmahalwy opened 6 years ago

mmahalwy commented 6 years ago

I'm submitting a ...

Current behavior: The Smartbanner component is heavily using CSS and should instead use styled-components

Expected / new behavior: Convert to styled-components please!

atalebagha commented 6 years ago

I can take this.

mmahalwy commented 6 years ago

@atalebagha please do! I will merge this soon: https://github.com/quran/quran.com-frontend/pull/1005

Then can open it up for everyone to help out. Still a few missing items that I need to do after I merge it inshallah

bahaa96 commented 6 years ago

Is this still open ?

mmahalwy commented 6 years ago

@bahaa96 Yep!

bahaa96 commented 6 years ago

The SmartBanner file is over 500 lines now do you prefer to move the styled components to a separate file ?

mmahalwy commented 6 years ago

Yes! Separation is always preferable :)

atiqueansari1987 commented 5 years ago

@mmahalwy Is this still open? If yes then can I pick it?

atiqueansari1987 commented 5 years ago

@mmahalwy Can you guide me what changes are needed?

fatmali commented 5 years ago

@bahaa96 did you finish working on this?

kaiyum2012 commented 3 years ago

@mmahalwy Just wondering this issue is still open?