search

quran / quran.com-frontend

quran.com frontend
https://quran.com
MIT License
986 stars 360 forks source link

Ayah out of range #1185

Closed whatsadebugger closed 3 years ago

whatsadebugger commented 3 years ago

Whenever I pick Al-Mulk and select an ayah that is too far from the first one i get an error. Open the surah and then select 25 for example.

image

whatsadebugger commented 3 years ago

tabba.ahmad@gmail.com if you could add me to slack.

whatsadebugger commented 3 years ago

On a similar note I can't load past ayah 10 in the bottom left corner.

image can't click after 10

mh453Uol commented 3 years ago

Seems to be a UI defect: Inside the console I see the following error Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22

You can easily reproduce this bug by going to

  1. https://quran.com/67
  2. Selecting "Play" on verse 11
  3. "Loading..." appears on the audio player
  4. Audio does not play

However going to https://quran.com/67/11?translations=20 (Url route which loads verse 11) the audio plays correctly. In addition the audio is available for verses 10+ see https://verses.quran.com/Alafasy/mp3/067011.mp3

I think its a issue with the following area of the component - https://github.com/quran/quran.com-frontend/blob/5c3d1f53a23639b6425a1cad0f9ba4d6a9bf55c2/src/components/Audioplayer/index.js#L93

Already a duplicate of the following PR - https://github.com/quran/quran.com-frontend/issues/1046