search

quran / quran.com-frontend

quran.com frontend
https://quran.com
MIT License
997 stars 360 forks source link

Should not let user select ayah past end of Surah #248

Closed mmahalwy closed 8 years ago

mmahalwy commented 8 years ago

For example /1/8 is not possible.

abiodun0 commented 8 years ago

is someone working on this?. If no I would love to work on it

mmahalwy commented 8 years ago

Salam @abiodun0, no one is currently! Would you like to grab it? How can I help guide you?

abiodun0 commented 8 years ago

Wa Alai Kum salam. I am willing to work on it . I have ran npm run dev on the forked repo. But I still do have error generating the main.js file on the repo. Can you help me on setting this up properly on my system?

abiodun0 commented 8 years ago

Do I need some sort of secret keys? @mmahalwy

abiodun0 commented 8 years ago

I'm contineously having this error. And the page doesn't seem to display well on my localhost @mmahalwy

screen shot 2016-06-13 at 6 49 36 am
ahmedre commented 8 years ago

set an environment variable for API_URL to be http://api.quran.com:3000. make sure you ran npm install and npm run build

not sure about why main.js isn't loading here - will let @mmahalwy chime in

mmahalwy commented 8 years ago

@abiodun0 what url are you going to? localhost:8000 or localhost:8001? 8001 is the dev one, not 8000!

abiodun0 commented 8 years ago

Jazzakumu Lahu Khairan @ahmedre The npm run build was what I was missing. Yes @mmahalwy I was using localhost:8001. I guess someone has to update the read me. Let me get to work on it. If either of you have time I would need someone to work me through the code and development process

mmahalwy commented 8 years ago

@abiodun0 happy to help. But nam run build is not the solution... it is when you're ready to push to production

abiodun0 commented 8 years ago

Can you drop your skype id or any IM i can send a message?

mmahalwy commented 8 years ago

@abiodun0 you can ping me on google hangouts: mmahalwy@gmail.com