quran / quran.com-frontend

quran.com frontend
https://quran.com
MIT License
998 stars 361 forks source link

[UX] No visual cues on error from server (keeps saying loading...) #301

Closed adiled closed 7 years ago

adiled commented 8 years ago

CANNOT REPRODUCE

Have been using the app for a while. I must say the UX is pretty good but one thing bugs me.

When there is an error on response from server, it stays stuck on loading... I think this is unexpected behavior.

screenshot from 2016-05-18 00 00 55

Synopsis28/5

Components Involved

mmahalwy commented 8 years ago

@designabyss thanks for filing this. Do you mind helping out with this?

adiled commented 8 years ago

@mmahalwy certainly wouldn't mind but it would be a week till I get free from college and pull out my coding keyboard!

mmahalwy commented 8 years ago

Okay sounds good! Ping me here when ready :)

adiled commented 8 years ago

@mmahalwy hey!

I have forked and cloned the project locally, ran npm install (btw it gave some errors in the end about some dependencies whining due to unsupported webpack version). Just point me in the right direction for build now Build successful.

Running into these build problems as of now

mmahalwy commented 7 years ago

@m-adilshaikh sorry i didnt see your last comment. Would love some help on this :)