[BUG] Ayah play button not working

quran / quran.com-frontend

quran.com frontend

https://quran.com

MIT License

990 stars 361 forks source link

[BUG] Ayah play button not working #383

Closed thabti closed 8 years ago

thabti commented 8 years ago

Clicking Play next to the Ayah doesn't work.

Would it be possible to introduce a repository project that would hold a set of functional tests? I introduced functional testing using Webdriver.io(JS) at the company I work for. If possible can we setup a repository quran/quran.com-functional-tests. I don't mind owning this.

mmahalwy commented 8 years ago

Yes, that has been known for a while and hasnt worked for a while now :S

thabti commented 8 years ago

Ah that's due to it not being implemented https://github.com/quran/quran.com-frontend/blob/develop/src/components/Ayah/index.js#L48

Should be triggering an audio player action.

thabti commented 8 years ago

I will submit a PR for this tomorrow inshallah.

mmahalwy commented 8 years ago

Yes. Sounds good!

thabti commented 8 years ago

Closing as a fix has been pushed to master, awaiting release.

mmahalwy commented 8 years ago

thank you!