Closed hellowin closed 7 years ago
You are certainly correct except the 8001. Not on my computer but pretty sure it's that and not 8000 which will not have hot reloading
Hmmm wait, I got these:
I haven't change anything yet. And look at these config:
Number 1. is not used? number 2 will get port 8000 because it's hardcoded on package.json
(number 3), is it as expected?
+1 thanks!
Can you please specify that these steps does not work on Windows.
sorry, what does not work?
I forked the project in both Ubuntu and Windows environnement and for both I ran npm run dev
for Ubuntu it works, for windows i got this
hmm i think the problem is with env
and probably should be export
I think for windows. Maybe we should use something else for env variables in command line. What to try moving those variables to .env
and see if it works?
@sabeurthabti +!
This part
Is no longer relevant. Some updates are:
development.env
is now.env
from localhost to api.quran.com
is alreadyAPI_URL=http://staging.quran.com:3000
http://localhost:8001
becomehttp://localhost:8000
nowBefore I create PR, is my points are true?