quran / quran.com-frontend

quran.com frontend

https://quran.com

MIT License

990 stars 361 forks source link

Player and Go to verse issues #760

Closed naveed-ahmad closed 7 years ago

naveed-ahmad commented 7 years ago

Player and go to verse dropdown has multiple conflicts:

Steps to reproduce issues:

Go to any Surah
Play the first verse
Select any verse from go to verse dropdown
1: Player will now play multiple verses simultaneously. Pause btn in player bar won't stop first recitation.
2: Go to 2/1, then select verse from dropdown which isn't loaded yet(> 10, say user select 30). Now user can't see first 10 verses yet player will keep playing them. BAD UX

IMO: `Go to verse` should stop currently playing verse and start playing selected one.

AhmedShab commented 7 years ago

@naveed-ahmad I will look into this if you like :smile:

AhmedShab commented 7 years ago

It looks like Mohamed is working on it. In that case, I can look for something else

mmahalwy commented 7 years ago

I think this is fixed no?