quran / quran.com-frontend

quran.com frontend
https://quran.com
MIT License
990 stars 361 forks source link

Audio playing error: Workaround to Adblock browser extension? #846

Closed drpalaric closed 6 years ago

drpalaric commented 7 years ago

Get the following error when trying to play a verse in Chrome 59.0.3071.115

screen shot 2017-07-14 at 3 10 15 pm
mmahalwy commented 7 years ago

Staging or production?

drpalaric commented 7 years ago

Production. I'll try Safari to see if I also get an error.

drpalaric commented 7 years ago

So, the issue is with Adblock Plus. If you have Adblock Plus installed, then it will block the audio files. I haven't seen this before on other sites, but if I am having this issue, I am sure others are as well. Perhaps there is a workaround to this. Maybe a pop-up or something to turn it off? ¯_(ツ)_/¯

mmahalwy commented 7 years ago

@ahmedre ^^

ahmedre commented 7 years ago

can you run the javascript console and add the error message you're getting when you try to play using Adblock Plus so that we can know where the actual issue is?

mmahalwy commented 7 years ago

We could definitely do that! We should do that as the solution!

drpalaric commented 7 years ago

@ahmedre the first issue is what the JavaScript console produces.

bahaa96 commented 6 years ago

Is this Issue still open ?? I've installed Adblock plus and it's working like charm. Either on staging or production.

drpalaric commented 6 years ago

if it's fixed, just close it then.

bahaa96 commented 6 years ago

Would you matter to check it now ?

drpalaric commented 6 years ago

Trying to play Surah al-Fatiha ...

Same issue running on Chrome:

raven.min.js:2 Audioplayer mounted but no file available
a.(anonymous function) @ raven.min.js:2

Firefox has the same errors. Here's something extra:

screen shot 2018-07-20 at 10 00 50 am

Some tests need to be written for this error.

naveed-ahmad commented 6 years ago

Salam brothers, I'm closing this. Issue have been fixed, but staging build are failing. Preparing for production build, and need to clear the fixed issues. They're scary :)