Edit Dockerfile from debian to buster

quran / quran.com-images

images using fonts from King Fahed Complex / qurancomplex.org

http://quran.com

390 stars 125 forks source link

Edit Dockerfile from debian to buster #51

Open SofiyanIfren opened 4 months ago

SofiyanIfren commented 4 months ago

Made two moidifications to make it working, as discussed in the following issue : https://github.com/quran/quran.com-images/issues/49

From Debian Jessie to Buster, because the binary-amd64 was not available inside the Jessie image, here it is for Buster : /debian-security/dists/buster/updates/main/binary-amd64
Removed the '\r' character which was causing this bug : /usr/bin/env: 'perl\r': No such file or directory (the '\r' was not removed from the perl files)

The image is now working fine al hamdouliLlah

ahmedre commented 4 months ago

jazakumAllah khairan for the PR - I merged #50, which had some of these changes along with bumping mysql. it's working for me now on macOS. where did you find this \r fix is needed since things are ok for me without it?

SofiyanIfren commented 3 months ago

Assalamou aleikoum sorry for the response time, I didn't receive the notifications...

I d'idn't try slim images for buster, I can do it if you want
For the \r char, it may be because I'm a windows user, it is common to have similar issues of misunderstood characters between the apple and the window ; I don't think modifying the file will be appropriate, as if I do it, it will be done from a different OS

May Allah agree our deeds

ahmedre commented 3 months ago

wa3laikum alsalam, no problem - i think the main branch should be working now without this patch, please give it a shot in sha' Allah. jazakumAllah khairan

SofiyanIfren commented 3 months ago

Just tried, the build is OK but I have a new error on the main branch, maybe the doc. is not updated :

λ docker-compose run gen /app/script/generate.pl --width 1300 --output ./output/ --pages 50 [+] Running 1/0

Container qurancom-images-mysql-1 Created 0.0s [+] Running 1/1
Container qurancom-images-mysql-1 Started 1.0s DBI connect('database=nextgen;host=mysql;port=3306','nextgen',...) failed: Can't connect to MySQL server on 'mysql' (115) at /app/script/../lib/Quran/DB.pm line 20. Died at /app/script/../lib/Quran/DB.pm line 20.

Shall I open a new issue ?