quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.01k stars 890 forks source link

Update the new Madinah Mushaf pages #1244

Closed ahmedkrmn closed 4 years ago

ahmedkrmn commented 4 years ago

After issue #575, the newer Madinah Mushaf pages became available under Settings>Page Type.

Currently, these new pages are for the Madinah Mushuf published from 1422 - 1439 AH. Starting from 1439 AH, an updated version of the Madinah Mushuf is being printed.

The attached image shows the difference.

The page on the right is from Quran app with Madani Mushaf selected as the page type. The page on the left is from the King Fahd Complex mobile application for the Madinah Mushaf. Mushaf

ahmedre commented 4 years ago

wa3laikum alsalam, jazakAllah khairan - we're using pages from the resources on the QuranComplex site - if these are updated, in sha' Allah we would be happy to update to the new font. will keep this open until we find out some information about this - if you do run across any updated data from QuranComplex please do update us on this ticket also.

jazakAllah khairan.

ahmedkrmn commented 4 years ago

@ahmedre I found the Mushaf on the new QuranComplex website, here is the link: https://qurancomplex.gov.sa/kfgqpc-quran-hafs-jawamee/

The old version of the website has the older Mushaf which is currently being used in the application: https://publications-img.qurancomplex.gov.sa/?p=26

Muslim010101 commented 4 years ago

@ahmedre I found the Mushaf on the new QuranComplex website, here is the link: https://qurancomplex.gov.sa/kfgqpc-quran-hafs-jawamee/

The old version of the website has the older Mushaf which is currently being used in the application: https://publications-img.qurancomplex.gov.sa/?p=26

How we can contact you Ahmad?

ahmedre commented 4 years ago

@ahmedkrmn jazakAllah khairan - unfortunately though these images are a bit tough to use since they have the white background instead of a transparent one and have borders. have a friend who is working on getting a more usable version of these so will consider using them if so.

@Muslim629 feel free to email me using my Github username at gmail

Muslim010101 commented 4 years ago

@ahmedkrmn جزاك الله خيرا

Muslim010101 commented 4 years ago

@ahmedre السلام عليكم و رحمة الله و بركاته How i can contact you?

ahmedre commented 4 years ago

وعليكم السلام ورحمة الله وبركاته please send me an email to [my GitHub username - ahmedre] at gmail

benomaire commented 4 years ago

Any updates on this? The 1441H print is available as vector images

  1. Here: https://dm.qurancomplex.gov.sa/Download/1441-AI-hafs.zip
  2. And mirrored here: https://archive.org/download/MushafMadinaHafsGreen1441/1441-AI-hafs.zip

I am willing to help. جزاكم الله خيرا

benomaire commented 4 years ago

If you want to use the new 1441H print, you can download this and replace related files in "new_madani". @ahmedre Your input is appreciated.

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته ماشاء الله It looks good, but it needs some changes in the end of Ayats symbol (number of Ayats in zakhrafah) like a real Mushaf. بارك الله فيكم و جزاكم الله خيرا

ahmedre commented 4 years ago

وعليكم السلام ورحمة الله وبركاته جزاك الله خيراً @benomaire sorry for not updating this prior, but al7amdulillah i actually prepared images based on the data from QuranComplex - exactly like yours, with a minor exception that i removed the green ayat markers so i can draw them in the same way that it happens in the current 1439 madani print.

will work on adding this to the app soon in sha' Allah. جزاك الله خيراً والسلام عليكم

benomaire commented 4 years ago

Good. Hope to see it soon. I was preparing another set of images using ayat symbols of the real printed Mushaf. I will not proceed then unless we agree on doing it. @ahmedre BTW, can you explain why you prefer drawing ayat markers in the app?

ahmedre commented 4 years ago

mostly because a lot of people contact us from time to time requesting "Arabic numerals" for ayah numbers (i.e. 1, 2, 3, ...) instead of (١، ٢، ٣, ...).

benomaire commented 4 years ago

Interesting! Guess what, one of my motivations to keep the number in the image is to have "2" showing like the right side of the attached image instead of the current shape on the left. bug2

Another motivation is #1419 Also, "ayah detection" script does not readily fill ayat markers positions in the database.

Anyways, Do you think these people requesting "Arabic numerals: 1, 2, 3, ..." are from non-western-arabian countries? and are requesting it specifcally for Mushaf Hafs of KFGQPC?

The following two links might be useful: 1- https://www.alukah.net/library/0/29751/ 2- https://waqfeya.com/book.php?bid=597 (page 122) جزاك الله خيرا

ahmedre commented 4 years ago

i actually don't think so - i think most of the people that are asking are Arabs from various countries that are used to reading with "1,2,..." numbers in their masahif - for example, the current warsh / qaloon masahif we have actually have "1, 2, ..." numbering of ayat from the page itself (not the app drawing it).

i am not extremely tied to this idea one way or the other to be honest - but since i already have the images and some brothers went through and took each page and checked them carefully after the scripts that ran, figure we might as well continue drawing programmatically here.

benomaire commented 4 years ago

I don't think it has a special unicode code. I generated both numbers in the image using this code but used this font for the one on the right. I thought of changing the font of the app globally but not sure how this will go for old API levels.

You are right about warsh and qaloon Massahif, but you know that KFGQPC did not adopt it in their print.

May Allah reward you for the efforts of manual revision, and I hope the eastern-arabic numbers (١، ٢، ٣, ...) stay the default if an option is offered, at least for Mussahif other than warsh and qaloon.

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته Jazekom Allah kheiren my brothers for this great job When I checked telawa with new version of Mushaf, I found issue in surah Alanfal n:8 Ayah 42 part of Ayah not highlighted "إذ" Screenshot_20200824-081742_Quran Screenshot_20200824-151417_Quran I fixed the issue here ayahinfo_1120.zip وجزاكم الله خيرا

benomaire commented 4 years ago

جزاك الله خيرا nice note. I found the issue also in:

  1. 19:3
  2. 26:142
  3. 51:25

but I feel lazy to fix it since it will not be used, and we are waiting for the version with @ahmedre. Also, I believe the fix is better done in the script.

ahmedre commented 4 years ago

جزاكم الله خيراً very nice catch both of you, barak Allah feekum. updated the script which found 22 such cases (including the 4 you mentioned). will try to update soon in sha' Allah.

ahmedre commented 4 years ago

here's an apk with the 1441 pages: http://cafesalam.net/uploads/new_madani_1441.apk

you have to go to settings -> page types and select the 1441 page type.

ahmedre commented 4 years ago

closing this issue since this is now done - please feel free to re-open if there are any issues. and may Allah reward you both for your efforts and for pushing this forward.

benomaire commented 4 years ago

ما شاء الله You have put a lot of efforts in that version. Well Done. May Allah reward you greatly.

Here are some comments in order of importance, which can all be ignored since the posted version is perfectly usable. However, since that is not public yet, you may like some of these:

  1. You previously mentioned there that the size of the first two pages is small. Was that missed accidentally here?

  2. In the apk, I don't see 1441, Rather: Classic, 1429, and 1431. Is 1431 a typo?

  3. 1432 is still relevant.

  4. Have you considered using the printed Green Zakhrafa for Surah Header? The highest quality I know is here. The main reason of discussing the color is that KFGQPC has released two Hafs versions in 1441H. They refer to the one we have here as green and to the other one as blue. The blue is just a new print of the Shemerly Mushaf.

  5. I claim that this testing version has better ayah highlighting in general as it misses less harakat (just a personal feeling, but did not compare them carefully).

وجزاكم الله خيرا

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته

Great job Mash'Allah Very good Zakhrafah of Surah name and Ayats like a real Mushaf. Just please change the images version in app settings to 1441 not 1431. We hope you add it with next app release soon Inshallah. وجزاكم الله خيرا جميعا

ahmedre commented 4 years ago

وعليكم السلام ورحمة الله وبركاته

  1. i'll have to revisit this again and see if i can make it bigger in sha' Allah.
  2. yeah it's a typo i'll fix in sha' Allah.
  3. hmm not sure, i'll check in sha' Allah, but was working for me.
  4. this is actually from KFGQPC iirc - here - it's not Shemerly.
  5. i can double check the line heights in sha' Allah - if you used quran/ayah-detection, mind giving me the line settings you used?

it is actually a real mushaf with its zakharef - i didn't draw them in this case. will fix the typo in sha' Allah. walsalam 3alaikum.

benomaire commented 4 years ago
  1. You are right, it is also here, and it is different from the blue of Shemerly. If you are not planning to include KFGQPC's Shemerly, then we can keep using the blue. Even if we include Shemerly later, the blue would still work. I was just suggesting to be consistent with the official app of KFGQPC, see the image below.

  2. See my fork, and crop-Mushaf-pages.

Screenshot ![kfgqpc](https://user-images.githubusercontent.com/69304392/92720866-e8be6c80-f36d-11ea-8665-e4253a1e801d.png)

وجزاكم الله خيرا

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته 5- I think is better to use changing font color for Ayah highlight like in مصحف المدينة Screenshot_20200910-221240_Google Play Store.jpg وجزاكم الله خيرا

ahmedre commented 4 years ago

@benomaire if it's ok to keep the blue ones (if they're identical except for the color), i'd prefer to keep it - i like the look of the markers better and the good thing is it's already been checked end to end. i do want to add Shemerly in the future (had a local copy and never shipped it, but was with a different copy and not the King Fahd one). i checked the cropping repository though and it doesn't show the values for identifying the lines - when you made the database, did you use quran/ayah-detection? if so, what values did you use for the line heights there? page 1 and 2 - i tried, but that was the best i could do - took the content as is and put it on the canvas with the same size of the images now - if i try to make it larger then it'll scale and won't look as good (the source files i have for the blue new madani mushaf are jpgs not the ai files).

@nacer80 this is a separate discussion and might not be very easy to do (on the image as a whole it's easy, but since the entire page is one image, doing it on one section of the image might be tricky unless there are canvas apis that let me apply this - will have to look though). maybe a separate ticket and can consider this one in the future in sha' Allah.

nacer80 commented 4 years ago

وعليكم السلام ورحمة الله وبركاته 1- I think about Zakhrafah is very good Mash'Allah just we have to fix the issue in page 1 and 2. 2- I will separate the issue of Ayah highlight (changing the font color) in new issue. جزاكم الله خيرا

benomaire commented 4 years ago

Sorry I should have been more clear. I used ayah-detection, and I shared two repositories:

  1. https://github.com/benomaire/ayah-detection/tree/KFGQPC-1441-AI-hafs
  2. crop-Mushaf-pages. Just to show you how I cropped, which is useless now I think.

For the blue color, you can keep it, I have no issue. May be the idea of copying all decisions of KFGQPC's main app is not a very good one anyways. For example, someone requested KFGQPC's to post blue version for the 604-page print, see the quote below from a comment here.

ما شاء الله تبارك الرحمن بيض الله وجهكم على هذا الابداع وشكر الله جهودكم في خدمة كتاب الله وعندي ملاحظة : لو طبع من المصحف الذي عدد صفحاته ٦٠٤ باللون الأزرق ايضا لكان خيرا فأنا أحب القراءة بالورقات الزرقاء وهذا مجرد اقتراح وإلا فجمال هذا العمل وظهورة بهذه الصورة يدل على حرصكم واجتهادكم وإخلاصكم والله يكتب لكم الأجر

Finally, I am ready to help on cropping pages 1 and 2 again from the .ai if you prefer that.

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته My brothers jazekoum'Allaho kheiren for this great efforts. وفقكم الله

Muslim010101 commented 4 years ago

السلام عليكم و رحمة الله و بركاته My brother can you tell me how you download this Mus'haf PDF in high quality?

https://qurancomplex.gov.sa/kfgqpc-quran-hafs-juzuamma/

On Sunday, January 19, 2020, Ahmed El-Helw notifications@github.com wrote:

@ahmedkrmn https://github.com/ahmedkrmn jazakAllah khairan - unfortunately though these images are a bit tough to use since they have the white background instead of a transparent one and have borders. have a friend who is working on getting a more usable version of these so will consider using them if so.

@Muslim629 https://github.com/Muslim629 feel free to email me using my Github username at gmail

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244?email_source=notifications&email_token=AMST2FFQM27T6C4ZAH624U3Q6SO6DA5CNFSM4KGXIIH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKZRHA#issuecomment-576034972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FAKD6EPOKK74DL2KM3Q6SO6DANCNFSM4KGXIIHQ .

benomaire commented 4 years ago

@Muslim629 If you have not figured that out yet, here is how:

  1. click the small arrow in the middle top of the box showing the quran pages.
  2. click on the arrow that says "download".
  3. Choose pdf.

Or you can just use this link which is basically what you will get from the above steps.

If you want to download the Mushaf for a windows PC, then you might want to download the windows option, I think it will look much better than the pdf. Also, I copied the link for you here.

Muslim010101 commented 4 years ago

جزاك الله خيرا

I use just in phone my brother, by the way in your app exist just hafs rewayah, qurancomplex release new Mus'haf warsh 2020 ai files, what do you think to add and warsh rewayah in your app?

On Friday, October 2, 2020, benomaire notifications@github.com wrote:

@Muslim629 https://github.com/Muslim629 If you have not figured that out yet, here is how:

  1. click the small arrow in the middle top of the box showing the quran pages.
  2. click on the arrow that says "download".
  3. Choose pdf.

Or you can just use this link https://epub.qurancomplex.gov.sa/issues/hafs/juzuamma/offline/download.pdf which is basically what you will get from the above steps.

If you want to download the Mushaf for a windows PC, then you might want to download the windows option, I think it will look much better than the pdf. Also, I copied the link for you here https://epub.qurancomplex.gov.sa/issues/hafs/juzuamma/offline/offline.exe .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244#issuecomment-702914803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FBEHWHBINMWDEIFRF3SIYR6NANCNFSM4KGXIIHQ .

benomaire commented 4 years ago

For warsh, feel free to open a new issue to discuss that. جزاك الله خيرا

nacer80 commented 4 years ago

السلام عليكم ورحمة الله وبركاته

We have this ussue already opened, please check #1280 وجزاكم الله خيرا

Muslim010101 commented 4 years ago

و عليكم السلام و رحمة الله و بركاته و خير جزاك الله

On Monday, October 5, 2020, nacer80 notifications@github.com wrote:

السلام عليكم ورحمة الله وبركاته

We have this ussue already opened, please check #1280 https://github.com/quran/quran_android/issues/1280 وجزاكم الله خيرا

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244#issuecomment-703564429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FAYAWHUYQQXMKALKITSJGS25ANCNFSM4KGXIIHQ .

Muslim010101 commented 4 years ago

و خير جزاك الله

On Monday, October 5, 2020, benomaire notifications@github.com wrote:

For warsh, feel free to open a new issue to discuss that. جزاك الله خيرا

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244#issuecomment-703527459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FFZE64H65WTZ4ZY5X3SJGJRHANCNFSM4KGXIIHQ .

benomaire commented 4 years ago

@Muslim629

  1. We are done with ayat markers, hopefully you will see it in the future.
  2. For Warsh, the link you posted does not work for me, but I think you mean this copy (this particular pdf is not made by KFGQPC, but of course based on KFGQPC files). Thank you for sharing that, I love it. However, I don't think we will use it in the app, because it is old, also see #1280.
  3. For Hafs Wasat, you have to download the images and convert them to pdf. I did that for you here and then found out that somebody did that before, I wish I searched first.
Muslim010101 commented 4 years ago

جزاك الله خيرا Yes, you are wrong Warsh PDF in vector art was work of qurancomplex but another person kotobatfal shared it on archive.

On Wednesday, October 7, 2020, benomaire notifications@github.com wrote:

@Muslim629 https://github.com/Muslim629

  1. We are done with ayat markers, hopefully you will see it in the future.
  2. For Warsh, the link you posted does not work for me, but I think you mean this copy https://archive.org/details/MushafWarsh_201701 (this particular pdf is not made by KFGQPC, but of course based on KFGQPC files). Thank you for sharing that, I love it. However, I don't think we will use it in the app, because it is old, also see #1280 https://github.com/quran/quran_android/issues/1280.
  3. For Hafs Wasat, you have to download the images and convert them to pdf. I did that for you here https://archive.org/details/MushafMadinaHafsWasat1440 and then found out that somebody did that before https://archive.org/details/1440_2020HQ, I wish I searched first.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244#issuecomment-705012620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FA2ZOU3V6YBET5Z4NLSJSCCVANCNFSM4KGXIIHQ .

Muslim010101 commented 4 years ago

@Muslim629

  1. We are done with ayat markers, hopefully you will see it in the future.
  2. For Warsh, the link you posted does not work for me, but I think you mean this copy (this particular pdf is not made by KFGQPC, but of course based on KFGQPC files). Thank you for sharing that, I love it. However, I don't think we will use it in the app, because it is old, also see #1280.
  3. For Hafs Wasat, you have to download the images and convert them to pdf. I did that for you here and then found out that somebody did that before, I wish I searched first.
  1. You mean to download first jp2 files than to convert it on PDF? Because i can't see any file in jpg just jp2
ahmedre commented 4 years ago

@Muslim629 would love your comments on #1280

also, for i actually did the pages for that exact Qurancomplex warsh version (the one with the pinkish colors), but several people mentioned that the writing style is a very old style that's not read by most of the youth today and were against releasing this as the primary one. please let's continue the warsh discussion in #1280 so we can figure out what the best thing to do is - and may Allah reward you greatly.

جزاك الله خيراً

nacer80 commented 4 years ago

السلام عليكم ورحمة الله @ahmedre I'm totally agree with brother @Muslim629 Lets use both version please see my comment in #1280 وجزاكم الله خيرا

Muslim010101 commented 4 years ago

@Muslim629 would love your comments on #1280

also, for i actually did the pages for that exact Qurancomplex warsh version (the one with the pinkish colors), but several people mentioned that the writing style is a very old style that's not read by most of the youth today and were against releasing this as the primary one. please let's continue the warsh discussion in #1280 so we can figure out what the best thing to do is - and may Allah reward you greatly.

جزاك الله خيراً

و خير جزاك الله

Muslim010101 commented 4 years ago

@Muslim629

  1. We are done with ayat markers, hopefully you will see it in the future.
  2. For Warsh, the link you posted does not work for me, but I think you mean this copy (this particular pdf is not made by KFGQPC, but of course based on KFGQPC files). Thank you for sharing that, I love it. However, I don't think we will use it in the app, because it is old, also see #1280.
  3. For Hafs Wasat, you have to download the images and convert them to pdf. I did that for you here and then found out that somebody did that before, I wish I searched first.

السلام عليكم و رحمة الله و بركاته

@benomaire

Can you send me your whatsapp number, to speak about converting to pdf, please! Because i'm not very active in github and gmail, just in whatsapp yes.

benomaire commented 3 years ago

@Muslim629

On Linux, you just run img2pdf.

For the compressed version, I used pngquant after scaling down the images.

Muslim010101 commented 3 years ago

@benomaire ok i now to convert pdf image to pdf, but isn't good quality, send me your whatsapp number to speak easy please!

androdusr18@gmail.com

benomaire commented 3 years ago

@ahmedre Please update the following pages. They are grayscale. May be add an extra color to each image, or use a tool that allows specifying the exact colors like GIMP. 037 040 048 069 079 107 113 206 358 UPDATE: check #1501

ahmedre commented 3 years ago

JazakumAllah khairan - I guess this is a result of the compression - May you open a fresh issue for this?

Muslim010101 commented 3 years ago

@Muslim629

  1. We are done with ayat markers, hopefully you will see it in the future.
  2. For Warsh, the link you posted does not work for me, but I think you mean this copy (this particular pdf is not made by KFGQPC, but of course based on KFGQPC files). Thank you for sharing that, I love it. However, I don't think we will use it in the app, because it is old, also see #1280.
  3. For Hafs Wasat, you have to download the images and convert them to pdf. I did that for you here and then found out that somebody did that before, I wish I searched first.

السلام عليكم و رحمة الله و بركاته

@benomaire

Can you send me your whatsapp number, to speak about converting to pdf, please! Because i'm not very active in github and gmail, just in whatsapp yes.

السلام عليكم ورحمة الله و بركاته @benomaire how are you my brother? Can you add in archive.org new Mus'haf Madinah 3 pdf?

https://qurancomplex.gov.sa/kfgqpc-quran-hafs-standardthree/

Muslim010101 commented 3 years ago

And tell me which is your new discussion in git'hub?

On Thursday, November 26, 2020, Ahmed El-Helw notifications@github.com wrote:

JazakumAllah khairan - I guess this is a result of the compression - May you open a fresh issue for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1244#issuecomment-734244891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMST2FDSXHFOFXR6CXNC76DSRY35NANCNFSM4KGXIIHQ .