Quran pages stretch to fill device display

[nacer80]

السلام عليكم ورحمة الله وبركاته I have one suggestion to make Quran pages stretch to fill device display as Ayah app. Screen shot from quran_android app: Screen shot from Ayah app:

[ahmedre]

وعليكم السلام ورحمة الله وبركاته جزاكم الله خيراً definitely want to do this in sha' Allah. جزاكم الله خيراً والسلام عليكم

[nacer80]

السلام عليكم ورحمة الله وبركاته Please I need your help to fix this issue وجزاكم الله خيرا

[ahmedre]

وعليكم السلام ورحمة الله وبركاته still working on it, just a bit too much on my plate at the moment. والسلام عليكم

[nacer80]

السلام عليكم ورحمة الله وبركاته

Also if there is an ability to make the font of the Qur'an darker (rougher)

[ahmedre]

work is in progress al7amdulillah -

[nacer80]

Mash'Allah great job, it looks good

[ahmedre]

السلام عليكم ورحمة الله وبركاته here is a debug apk for the app (can be installed side by side with the real version) that has the larger images. please try it and let me know in sha' Allah.

settings -> page type. cc @nacer80 @benomaire جزاكم الله خيراً والسلام عليكم

[nacer80]

وعليكم السلام ورحمة الله Mash'Allah, it looks very good, I tested it in Samsung note 10+. Also surah names are good now, I hope we make a same for last version1441، or change the Zakhrafah of Ayats and Surah. جزاك الله خيرا

[ahmedre]

وعليكم السلام ورحمة الله وبركاته glad to hear it - for the sura names, I haven't applied your new database yet. جزاكم الله خيراً والسلام عليكم

[benomaire]

Overall, very nice work. But I have three notes:

1. After downloading the images and preparing the 9000+ files, the app showed a black screen, and the system showed the "Quran Madani not responding" dialog. Few seconds later, the first page of the Quran loaded normally. Not sure why this slowness. [UPDATE: seems to be relevant on old devices]
2. using landscape mode (without dual pages), the page number is floating on the screen (I mean the position of the page number depends on the physical screen rather than the Quran page). Not sure if that is intentional.

3. 1767 (happened to be on master as well, so wrote a separate issue).

4. Surah name at the top of every page is sometimes cropped from the bottom, despite being far from the Quran text (can be seen in dual page mode).

جزاكم الله خيرا

[ahmedre]

@benomaire JazakumAllah khairan - one question about point 1 - when exactly did the ANR happen? if you can repro it, can you send me the traces.txt? I checked the code and see that all of this runs on a background thread. was it when you clicked a sura to open it (after the download was done and you saw the list), or was it just the first time after the download and preparing files happened, or?

for point 2 - initially was intentional but will fix it in sha' Allah. for point 4 - may you send a screenshot and tell me what device this is on?

[nacer80]

السلام عليكم ورحمة الله وبركاته I tested the app on Samsung devices(A,S and Note) till now it's ok, About the point 1, we have to download all the pages. If one page missed the app stopped even we restart the app we can't open the other pages. Also I found one issue while shearing tafseer, when we have one tafseer, we can't copy or share. السلام عليكم ورحمة الله

[ahmedre]

وعليكم السلام ورحمة الله وبركاته جزاكم الله خيراً

@nacer80 - You're right - yeah there's no dynamic downloading of the line by line images today, and not really planning to do it - so instead if the download fails now or is canceled or ignored, I reset the page type to the new madani page type instead.

Fixed the sharing bug you mentioned also.

@benomaire fixed the footer, but didn't do anything yet for cut off header. I checked the code and all the screen is used, so perhaps there's too much padding - if you can tell me the type of device and send a screenshot would help. also, please let me know about the ANR.

I'll update with an updated APK after fixing some more of these issues in sha' Allah.

جزاكم الله خيراً والسلام عليكم

[ahmedre]

with respect to zakhrafa, I talked to a designer and he made some samples - would love to get some votes on these. I think once we have one I can ask for similar ayah designs to the sura designs.

today: http://cafesalam.net/uploads//zakhrafa_today.png style 1: http://cafesalam.net/uploads/zakhrafa_1.png style 2: http://cafesalam.net/uploads/zakhrafa_2.png style 3: http://cafesalam.net/uploads/zakhrafa_3.png style 4: http://cafesalam.net/uploads/zakhrafa_4.png style 5: http://cafesalam.net/uploads/zakhrafa_5.png style 6: http://cafesalam.net/uploads//zakhrafa_6.png

[nacer80]

وعليكم السلام ورحمة الله

About Tafseer sharing format please check the issue #1769 About Zakhrafah I choose number 4.

وجزاك الله خيرا

[Haroun-98]

السلام عليكم ورحمة الله

Good job brothers. About Zakhrafa n 4 and 5 are the same, it looks good.

[nacer80]

السلام عليكم ورحمة الله وبركاته There is an issue while choosing repetition times, Ex: if we choose repetition 3 times and at this moment if the reciter read the next Ayah، the counter go back automatically to 1.

[Haroun-98]

السلام عليكم Please add page number to search results

[ahmedre]

وعليكم السلام ورحمة الله وبركاته closing this now since the repeats one was fixed and page number was added to search results. جزاكم الله خيراً والسلام عليكم