search

quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.01k stars 890 forks source link

Highlight feature for "motashabehat" and other on-page metadata #1845

Open tarekeldeeb opened 2 years ago

tarekeldeeb commented 2 years ago

I woud like to have a highlight feature with different colors. Tapping a highlighted text would open a popup with some more info. Applications are countless:

Currently, I can see from the sources that only-Aya boundaries are known. No word boundaries are defined. Is this true? What are possible solutions than manual entry?

ahmedre commented 2 years ago

we actually have data for the old madani images - someone already opened a PR in #1720 to support some of this. I think the associated data today is just the word meaning in English and maybe some other languages.

for the other page types, it's tricky without manual entry - I did write a script in Python to use Google cloud apis to try to detect the words, but it still doesn't have a very high accuracy - if you'd be interested I can open source what I have and you can try to play with it some.

tarekeldeeb commented 2 years ago

Thanks Ahmed for clarifying the topic.

May you share your python scripts? I think I'll proceed in both directions: [1] Old Madani (default) and adding support for other pages, too. I'm CCing Dr. Yasmeen Farouk, who's interested in the topic as well.

Regards,

Tarek Eldeeb | طارق الديب https://www.linkedin.com/in/tarekeldeeb Sr. SW R&D Manager | FPGA Expert

On Fri, Jan 14, 2022 at 8:13 PM Ahmed El-Helw @.***> wrote:

we actually have data for the old madani images - someone already opened a PR in #1720 https://github.com/quran/quran_android/pull/1720 to support some of this. I think the associated data today is just the word meaning in English and maybe some other languages.

for the other page types, it's tricky without manual entry - I did write a script in Python to use Google cloud apis to try to detect the words, but it still doesn't have a very high accuracy - if you'd be interested I can open source what I have and you can try to play with it some.

— Reply to this email directly, view it on GitHub https://github.com/quran/quran_android/issues/1845#issuecomment-1013347612, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWG2KA63K3CD3GW5BGNCTUWBRUBANCNFSM5L66XLQQ . You are receiving this because you authored the thread.Message ID: @.***>

ahmedre commented 2 years ago

please feel free to drop me an email - ahmedre at gmail if you prefer to continue this over email (replying to this email posts to the original Github issue).

for the old madani, probably let's clean up and figure out how to merge the existing PR since the work was already done. will share the scripts in sha' Allah (if you send me an email can send them to you, otherwise can perhaps try to open source them at some point).

jazakumAllah khairan. walsalam 3alaikum.