quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
1.98k stars 883 forks source link

Fix column name issue with translation database #2538

Closed ahmedre closed 7 months ago

ahmedre commented 7 months ago

Older versions of the translation database (versions 2 and 3) added and had a translator_foreign field. In version 4, this was renamed to translatorForeign. The code assumed it was always named as translatorForeign, which is incorrect, thus crashing for people upgrading from older versions.

github-actions[bot] commented 7 months ago
OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │  12.6 MiB │  12.6 MiB │ +18 B │    32 MiB │    32 MiB │ +4 B 
     arsc │   2.2 MiB │   2.2 MiB │   0 B │   2.2 MiB │   2.2 MiB │  0 B 
 manifest │   5.6 KiB │   5.6 KiB │   0 B │  27.1 KiB │  27.1 KiB │  0 B 
      res │   1.6 MiB │   1.6 MiB │   0 B │   1.8 MiB │   1.8 MiB │  0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │  0 B 
    other │ 189.2 KiB │ 189.2 KiB │ -14 B │ 387.5 KiB │ 387.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │    17 MiB │    17 MiB │  +4 B │  37.1 MiB │  37.1 MiB │ +4 B