quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
1.96k stars 879 forks source link

Merge BookmarkModel into BookmarksDao #2584

Closed ahmedre closed 5 months ago

ahmedre commented 5 months ago

Before this patch, there were 2 BookmarkModel classes, one in Java, and one in Kotlin. This patch merges the Kotlin one into BookmarksDao, and deprecates the Java BookmarkModel class.

github-actions[bot] commented 5 months ago
OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  20.2 MiB │  20.2 MiB │ -632 B │  65.1 MiB │  65.1 MiB │ -1.7 KiB 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │    0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 188.6 KiB │ 188.6 KiB │   +6 B │ 385.6 KiB │ 385.6 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  24.6 MiB │  24.6 MiB │ -626 B │  70.2 MiB │  70.2 MiB │ -1.7 KiB