search

quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.02k stars 891 forks source link

circular dependency #2686

Closed amirian closed 6 months ago

amirian commented 6 months ago

After the last commit (merging 2681 pull request), apk generation is stopped with the following error: Circular dependency between the following tasks: :app:generateMadaniReleaseRFile \--- :app:parseMadaniReleaseLocalResources \--- :app:packageMadaniReleaseResources \--- :app:injectCrashlyticsMappingFileIdMadaniRelease +--- :app:kaptMadaniReleaseKotlin | \--- :app:kaptGenerateStubsMadaniReleaseKotlin | +--- :app:generateMadaniReleaseRFile (*) | \--- :app:kspMadaniReleaseKotlin | \--- :app:generateMadaniReleaseRFile (*) \--- :app:kspMadaniReleaseKotlin (*) even ./gradlew clean and ./gradlew --rerun-tasks won't help. Making project is perfect, the error rises in apk generation.

ahmedre commented 6 months ago

it's building fine both here and in CI/CD - i didn't try a release build, but did a debug build and it was fine - ./gradlew assembleMadaniDebug - can you try that and see if it's working? are you sure you have no other changes in your branch?

amirian commented 6 months ago

assembleMadaniDebug works fine, assembleMadaniRelease does not. I have made changes with no difference in dependencies. Moreover, my changes made no issues till your last commit.

amirian commented 6 months ago

I already tried your main branch, it also generates the error.

ahmedre commented 6 months ago

Ok I can repro now - two workarounds while I find a fix - either set crashlytics in gradle/libs.versions.toml back to 2.9.9, or compile using -PdisableFirebase

amirian commented 6 months ago

That's it, the firebase bug. They are having that fixed.

amirian commented 6 months ago

That's it, the firebase bug. They are having that fixed.

amirian commented 6 months ago

Crashlytics bug is fixed within v3.0.1, I'n not permitted to create a branch and update the dependency.

ahmedre commented 6 months ago

I am waiting for 3.0.2 because there's a problem with 3.0.1 also

amirian commented 6 months ago

They mentioned the issue is related to a package for Google services not the crashlytics. I have tested 3.0.1 and confirm it is resolved in the release. Anyway, you can wait for a new version but it will not be about this bug.

amirian commented 4 months ago

3.0.2 has come for a while, why sticking on 2.9.9?

ahmedre commented 4 months ago

merging in #2781