search

quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
1.95k stars 881 forks source link

Improve Polish language translations #2747

Open BilalHassona opened 1 week ago

BilalHassona commented 1 week ago

Assalamu alaykum, I would like to improve Polish langugage translations in the Android app. As far as I know they are ChatGPT-generated. I could improve those translations as I am native Polish speaker and fluent in English (Level C1/C2). I already prepared a PR for web app: https://github.com/quran/quran.com-frontend-next/pull/2120 Now I would like to do the same for Android and iOS apps (for iOS I will create a separate issue). Would that be accepted and merged? I am mid/senior front-end dev - I don't know much about Android/iOS development but I plan to use this old issue and translate all files mentioned there: https://github.com/quran/quran_android/issues/2284

ahmedre commented 1 week ago

wa3laikum alsalam, actually, they're not ChatGPT generated - I think the problem though is we somehow renamed the Portuguese translations into Polish translations, which is wrong. If you see here, you'll see at the bottom that it was renamed from values-pt, which seems incorrect to me. I traced it back to #1927 from @benomaire.

would really appreciate PRs to fix this in sha' Allah! I guess on top of the paths listed in the issue you mentioned, any values/strings.xml file you find should have a corresponding values-pl/strings.xml file with all the translatable strings in it (i.e. anything except strings that say translatable=false).

jazakumAllah khairan, walsalam 3alaikum

BilalHassona commented 1 week ago
  1. in the issue you mentioned, the file: https://github.com/quran/quran_android/pull/1927/files#diff-33eb97878bc1c93d6b6371526b256ce286ecbff23bda6bb385c80bc5104bf1f4 was renamed from values-pt to values-pt-rBR, not to values-pl. I am not sure if this was intended change (or if it was fixed later) and if the Portuguese language works correctly, but Polish version of the app works well (I use the latest version downloaded from the Google Play Store) - the only problem I see is that some translations could be improved.
  2. @benomaire conacted me in April and said that these Polish translations are auto-generated. I checked some files in the repo and I see room for improvement: some words aren't conjugated properly, some sentences could be clearer and some strings aren't translated at all (even in the app from the Play Store on my phone). I plan to review all the files and correct everything I find in sha Allah. I love this app and I have been using it for many years. May Allah reward you greatly for all the work.
ahmedre commented 1 week ago

Wa3laikum alsalam, JazakumAllah khairan for the clarification! Would really appreciate the PRs, and may Allah reward you greatly. Walsalam 3alaikum

BilalHassona commented 1 week ago

Assalamu alaykum, awesome, I will prepare the changes then. It will probably take around a week. JazakaAllahu khairan, assalamu alaykum.