quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.02k stars 892 forks source link

Fix the page not being saved in some cases #2934

Closed ahmedre closed 3 weeks ago

ahmedre commented 3 weeks ago

Canceling a CoroutineScope automagically cancels anything launched into it after the fact. Instead, keep a job for the subscription, and cancel that instead of the scope.

github-actions[bot] commented 3 weeks ago
OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │  21.3 MiB │  21.3 MiB │  +5 B │  68.1 MiB │  68.1 MiB │ +120 B 
     arsc │   2.3 MiB │   2.3 MiB │   0 B │   2.3 MiB │   2.3 MiB │    0 B 
 manifest │   5.6 KiB │   5.6 KiB │   0 B │    27 KiB │    27 KiB │    0 B 
      res │   1.6 MiB │   1.6 MiB │  +6 B │   1.8 MiB │   1.8 MiB │    0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │ 195.9 KiB │ 195.9 KiB │  +5 B │ 404.5 KiB │ 404.5 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  25.7 MiB │  25.7 MiB │ +16 B │  73.2 MiB │  73.2 MiB │ +120 B