quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.01k stars 890 forks source link

Ability to pinch zoom in pages #436

Closed ismusidhu closed 9 years ago

ismusidhu commented 10 years ago

Many a times I feel need of zooming in. I hope there are others also who feel so.

ahmedre commented 10 years ago

honestly, unlikely we'll do it, despite many people having asked for it at some point or another.

reasons:

  1. ui/ux would be non-ideal with the swiping between pages, etc.
  2. the images are in "full size" in landscape - so it would be the same size as being in landscape.
  3. using larger images would lead to more memory issues.
ibnharoon commented 10 years ago

Any plans to move to SVG format? AFAIK there are a few SVG libraries for the android. The question is whether it's fast enough for the app. I have the madani pages in SVG.

ahmedre commented 10 years ago

we'd like to if possible.

are they actually svg images or are they svg fonts? the android libraries don't support svg fonts (the ones i looked at anyway), but if they are actual svg images, i'd be interested to try it out and see how well it works - if it works well, this could be a good move since it would likely make life a lot easier than it is now (having to figure out screen size, generating images accordingly, etc).

jazakAllah khairan.

ibnharoon commented 10 years ago

They are not fonts they are actual pages in vector graphics. Here is a sample of the first page: https://github.com/ibnharoon/quranwebservice/blob/master/apps/images/page001.svg

Sample web app that use SVG: http://quranwebservice.appspot.com/apps/Quran.html

Wa iyakum

aessam commented 9 years ago

I like the SVG solution.

ahmedre commented 9 years ago

likely won't be doing this now - in the future, we want to switch to the new madani pages. svg support is non-native on android, there are some libraries but they don't support some of the things, however, so not sure about this moving forward.