Closed ahmedre closed 4 years ago
+1 I would find the 1st feature to be very useful for me personally.
Great , Looks simple, I could start with it .....but not the widget designs :)
Brothers,
I'm Almost done with a simple widget of 3 buttons that simplly have the search function and the last page function and the jump function, but the implementation i have made is so simple where i navigate to the pre made function , so for example if the user presses the search button in the widget i simply navigate to the QuranActivity and call the onSearchRequested() callback method. So are you thinking of something more complicated ? Please let me know if you have other thoughts in mind.
Salam.
salam 3alaikum, thinking out loud - from what i remember, we can't actually input text in a widget (but we can pop up a transparent activity or something when the user interacts with something). is it really a common use case that people would know, "hey, i want to jump to sura x ayah y?" - search may be more useful, along with maybe a one tap to get to your last place.
i think also an "ayah of the day" type widget could be neat, but maybe outside the scope of what Quran Android should be doing. walsalam 3alaikum.
salam 3alaikum, i was wondering if my pull request reached you for the widget feature? Wa jazakum allah khayran @ahmedre
wa3laikum alsalam, i just tried it today, i am really sorry, i forgot. i like the idea behind this and the fact that it provides quick access, but the ui needs to improve. i especially love the one touch to get to the last page you were reading, i think that's great!
how do you feel about us actually having a list of bookmarks in the widget? i can try to see if i can get us some designs (will take at least 2 weeks though insha'Allah) so we can iterate on this and get it shipped out?
walsalam 3alaikum.
السلام عليكم, Well glad you liked it , and as you said the designs needs to improve ,and in fact i have not spent time at all in modifying it since i'm not very good at designing , and thought that anyone could just plug these icons with the suitable images for each of the 3 widget options or of coarse if someone would like to change completely how it looks. I could work also on a fourth widget option to get bookmarks in the weekend , but still will actually not spend so much time on how it looks , but can do something basic design though like a custom list view with a quran icon somewhere in the list view plus of coarse the text reference of bookmark and again someone could just come out and plug the suitable image or maybe change it's position so it would look nice. Regarding shipping, do you mean merging my branch with the master? وجزاكم الله خيرا @ahmedre
@Hello :) @ahmedre
sorry for the delay - insha'Allah let me get back to you this weekend.
salam 3alaikum, sorry for the really delayed reply.
presumably, a smaller widget would look something like this:
a widget containing bookmarks could look something like this:
walsalam 3alaikum.
salam 3alaikum, Great ,should i start working with these images and cut out the icons as separate files ? i think most of these icons already exist in the project except for the jump icon.
wa3laikum alsalam - for jump, use the "reply" icon from https://github.com/google/material-design-icons. will insha'Allah get the arabic Quran logo. the rest should already be in the app.
السلام عليكم Any updates on this widget issue? Why isn't it yet implemented? وجزاكم الله خيرا
Wa alaikum assalam @lessmore618.
As can be seen from the linked PRs, proposed changes are not quite production ready.
@ahmedre Are you still need implement this widget?
FYI I've done some work on #845 and got it to work with the latest code in this repo. But:
BookmarksDBAdapter
is still tightly coupled to the bookmarks widgetInshallah I'll get there soon (if I keep reminding myself to do it as well..). My code hasn't yet been pushed to Github yet either, Inshallah I'll do that soon as well..
jazakAllah khairan, looking forward to it!
I've created #1378 and put some comments on for people to feedback on (cc @ahmedre). There is still various stuff for me to do on the PR for it to be ready to merge.
@ismail-s - jazakumAllah khairan - sorry i know i've been slow about this :( will get to it soon in sha' Allah and do really appreciate your help and may Allah reward you greatly
from an email we got (and i think we should definitely think about this, these are some good ideas masha'Allah):
Assalamu Alaikum and jazakumumullahu katheeran
I would like to urge the team to not miss a great opportunity for much reward. Two features in a widget form will do wonders for the ppl of Quran, the family of Allah, the best Muslims:
So while typing this email i could quote ayaat very quickly, especially if you can design a keyboard add-on (that's third feature actually?)
Jkkk
Salam.