quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.02k stars 892 forks source link

Translation to surah names #673

Closed habibr closed 7 years ago

habibr commented 8 years ago

Is there a way to translate the surah names? I do not see them in the strings.xml.

ahmedre commented 8 years ago

yes, they are in sura_names.xml - i don't think we're showing them in the app right now though

ozbek commented 8 years ago

Please see surah_names.xml

https://github.com/quran/quran_android/blob/master/app/src/main/res/values/sura_names.xml

habibr commented 8 years ago

Although the surah names in english and in Indonesian (or other languages) might be similar, the readers could see the names a bit strange and some questions could arise within themselves. I just showed the qur'an to my daughter and she directly pointed out the strange names of the surahs... :)

I think it would be a nice addition to the app if the surah_names.xml could be translated. I would be happy to translate them...

ahmedre commented 8 years ago

the sura_names_translation array is currently translated only in English and Russian - nothing stops other apps from translating it, we're just not showing it yet afaik, but we could/should.

ozbek commented 8 years ago

Russian locale shows both names: Arabic transliteration and Russian translation. In fact, that was first requested by Russian users.

habibr commented 8 years ago

ok, i will copy the strings to values-in to prepare for the indonesian version of the surah names.

ahmedre commented 8 years ago

@ozbek ah i forgot about this - should we enable this for all languages?

ozbek commented 8 years ago

Check out show_sura_names_translation:

https://github.com/quran/quran_android/blob/master/app/src/main/res/values/booleans.xml

habibr commented 8 years ago

So, @ozbek, I should also copy this booleans.xml and set the translation there?

ozbek commented 8 years ago

Yes, but there is no need to copy everything. Just set show_sura_names_translation to true.

ozbek commented 8 years ago

should we enable this for all languages?

Somehow, I have missed this part. Previously, we have agreed to enable/disable that feature based on show_sura_names_translation value per locale.

ahmedre commented 7 years ago

closing for now, please re-open if anything is needed.