search

quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
1.99k stars 882 forks source link

Reorganize Settings Menu #704

Closed ahmedre closed 7 years ago

ahmedre commented 7 years ago

The settings menu is getting a bit unwieldy.

Thoughts:

  1. maybe move "Advanced Options" into a separate screen
  2. maybe move "Display Options" into a separate screen
  3. move "Volume Key Navigation" under Reading preferences

"maybe" because I could be convinced either way - open to feedback.

ahmedre commented 7 years ago

anyone should feel free to work on this and send a PR

ozbek commented 7 years ago

move "Volume Key Navigation" under Reading preferences

+1... OK, no "maybe" there, but still I voted :)

ahmedre commented 7 years ago

lol, everything should be considered a maybe :)

ozbek commented 7 years ago

maybe move "Display Options" into a separate screen

Regarding "Display Options", this seems to overlap with "Reading Preferences". For example, "New background" or "Lock screen orientation" could have been in "Reading Preferences", or "Show page info" or "Highlight bookmarks" could be put to "Display Options".

Only "Arabic mode" does not seem to fit to "Reading Preferences" as that's purely about the UI. Is it not time to remove that option altogether? Android supports Arabic natively now.

ahmedre commented 7 years ago

i am good with your PR - but just wanted to comment on the Arabic setting - i personally use this (despite my phone being in English as the default locale) - i think it probably gets a lot of use from:

  1. people who speak Arabic fluently but usually converse in English - so they leave their phones in English and just enable Arabic for Islamic apps when the option is there
  2. people who are learning Arabic

so i personally would be sad if this went away :(